General Discussion

ello all,

just updated to version 0.7.9 and it resolved the issues with level, symb and pb, so that's awesome. but still having this problem with guestlist reinvite. When bot restart it tells me (sometimes) "You have been reinvited to the private channel" but it never actually does so...

anyone an idea what the problem here could be?

Greetings,




Ellarisa

side note: bot still running great on my linux machine

This is strange, I've looked at the reinvite code and I can't see anything really "wrong" with it, though in my experience I've never gotten the reinvite message if I accidentally or intentionally clicked the "no" button on when bot invites one of my toons to guest channel.

If the bot is able to invite you, it should be able to reinvite you.  It appears to be the same function call, and if you're getting the reinvite message, you should be getting the invitation.

If you look in the plugins directory at the file vh_PrivateGroup.cs in a text editor and scroll down to where you get sent the reinvite message, you should see:

Code:

.
.
.
                foreach (UInt32 user in users)
                {
                    this._database.ExecuteNonQuery("DELETE FROM pg WHERE user = " + user);
                    this._bot.SendPrivateMessage(user, this._bot.ColorHighlight + "You have been reinvited to the private channel");
                    this._bot.PrivateChannel.Invite(user);
                }
.
.
.

That's the only place I see the "You have been reinvited" message in the bot code.  It seems to trigger for guest channel members who are not in guest chat every 5000 seconds.  If you got sent the message, the very next thing that should happen is that you get sent the invite.  If you look elsewhere in the code, the "join", "invite", and logon trigger all use bot.PrivateChannel.Invite(user).

If you're timer code above doesn't include the bot.PrivateChannel.Invite line after the bot.SendPrivateMessage, then that would be the problem.

I've always been perplexed as to why this doesn't work as expected .. particularly if the bot crashes or disconnects and then nobody re-connects to the guest-chat. It seems sporadic, sometimes it works .. sometimes it doesn't .. and I have tried a few bodges to make it work better, without succeeding at fixing the original problem.

It -could- potentially be a problem with invite flood .. but that doesn't seem to occur with the 'bodges' I've created.

We'll look into it further ... !

PS. Llie .. I wondered whether it was an issue with the db table .. so used it to track people who should be On the guestchat .. since I didn't understand the original purpose for the db table .. still with mixed results. Any thoughts welcomed!

It's likely an issue where invites are sent out too early after reconnecting.
I suspect the chat server ignores certain packets when they come in really early.
The private message is unaffected as it goes into a separate more throttled packet queue.

I suggest trying to add a bigger delay between the moment the bot connects and the moment re-invites are sent out.

looks like it's as vhab says, cause when i raise the timer interval to 20 seconds it seems to work (10 seconds didn't seem to work either).
Another issue solved (for me at least  ), thanks for the help!
Greetings,



Ellarisa

Glad to hear that seems to work .. we'll try to get that patched for future versions